Linux Kernel Contributions

This is a list of my Linux kernel contributions scraped from Linux kernel mailing list archive on lore.kernel.org by a miserable shell script run periodically with cron.

The script was last run on Wed Oct 4 07:25:45 UTC 2023

[PATCH V4] staging: r8188eu: Remove broken rtw_p2p_get function. - by Charlie Sands @ 2022-04-30 4:28 UTC

Removes broken and unsafe rtw_p2p_get function and all of the code
associated with it from the r8188eu driver.

Signed-off-by: Charlie Sands 
---

Follow up to the patch called "staging: r8188eu: Fix unsafe memory access
by memcmp." 

V2: Fixed checkpatch.pl warning and changed variable name as suggested

[PATCH V3] staging: r8188eu: Fix unsafe memory access by memcmp. - by Charlie Sands @ 2022-04-06 11:25 UTC

This patch fixes sparse warnings about the memcmp function unsafely accessing 
userspace memory without first copying it to kernel space.

Signed-off-by: Charlie Sands 
---

V2: Fixed checkpatch.pl warning and changed variable name as suggested by Greg
K. H. and improved error checking on the "copy_from_user" function as suggested
by Pavel Skripkin.

[PATCH V2] Fix unsafe memory access by memcmp - by Charlie Sands @ 2022-04-04 2:52 UTC

This patch fixes sparse warnings about the memcmp function unsafely
accessing userspace memory without first copying it to kernel space.

Signed-off-by: Charlie Sands 
---

V2: Fixed checkpatch.pl warning and changed variable name as suggested
by Greg K. H. and improved error checking on the "copy_from_user" function as
suggested by Pavel Skripkin.

[PATCH] staging: r8188eu: Fix unsafe memory access by memcmp. - by Charlie Sands @ 2022-04-01 20:12 UTC

[PATCH V2] staging: r8188eu: Fix sparse endianness warnings - by Charlie Sands @ 2022-03-30 18:52 UTC

This patch fixes sparse warnings about the endianness of different
pieces of data in the driver.

Fixes: 15865124feed ("staging: r8188eu: introduce new core dir for
RTL8188eu driver")
Signed-off-by: Charlie Sands 
---
V2: Added the "fixes" line to the commit at the request of Dan Carpenter.

 drivers/staging/r8188eu/core/rtw_br_ext.c | 12 +++++++-----

[PATCH] staging: r8188eu: Fix sparse endianness warnings. - by Charlie Sands @ 2022-03-30 3:14 UTC

This patch fixes sparse warnings about the endianness of different
integers in the driver.

Signed-off-by: Charlie Sands 
---
 drivers/staging/r8188eu/core/rtw_br_ext.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/r8188eu/core/rtw_br_ext.c b/drivers/staging/r8188eu/core/rtw_br_ext.c
index d68611ef22f8..ed41c4e30262 100644

[PATCH V2] staging: rts5208: Resolve checkpatch.pl issues. - by Charlie Sands @ 2022-03-17 2:53 UTC

This patch removes unwanted use of dev_info for ftrace-like functionality
as suggested by checkpatch.pl.

Signed-off-by: Charlie Sands 
---
V2: fixed bad commit message and compiler warning

 drivers/staging/rts5208/rtsx.c | 8 --------
 1 file changed, 8 deletions(-)

Re: [PATCH] staging: rts5208: Resolve checkpath.pl issues. - by Charlie Sands @ 2022-03-15 21:15 UTC

> Always test-build your patches. Applying this change results in a build 
> failure :(
My apologies, I ran a build test on a copy of the repository with my changes
stashed in order to look at the original checkpatch warnings.

> Please fix up and resend.
It should now fix the below issues without build warnings.

WARNING: Unnecessary ftrace-like logging - prefer using ftrace
+ dev_info(&dev->pci->dev, "%s called\n", __func__);

[PATCH] staging: rts5208: Resolve checkpath.pl issues. - by Charlie Sands @ 2022-03-15 2:27 UTC

This patch remedies the following checkpath.pl issues:

WARNING: Unnecessary ftrace-like logging - prefer using ftrace
+ dev_info(&dev->pci->dev, "%s called\n", __func__);

WARNING: Unnecessary ftrace-like logging - prefer using ftrace
+ dev_info(&dev->pci->dev, "%s called\n", __func__);

WARNING: Unnecessary ftrace-like logging - prefer using ftrace
+ dev_info(&pci->dev, "%s called\n", __func__);